zhouyejoe commented on a change in pull request #33078: URL: https://github.com/apache/spark/pull/33078#discussion_r659244070
########## File path: core/src/main/scala/org/apache/spark/SparkContext.scala ########## @@ -583,6 +583,7 @@ class SparkContext(config: SparkConf) extends Logging { _applicationId = _taskScheduler.applicationId() _applicationAttemptId = _taskScheduler.applicationAttemptId() _conf.set("spark.app.id", _applicationId) + _applicationAttemptId.foreach(attemptId => _conf.set("spark.app.attempt.id", attemptId)) Review comment: IIUC conf/packages.scala includes all the public configuration keys. This should be an internal one. I am also referring to other similar codes as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org