dongjoon-hyun commented on a change in pull request #33101:
URL: https://github.com/apache/spark/pull/33101#discussion_r659365113
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -285,16 +285,12 @@ private[spark] object Utils extends Logging {
*/
def createDirectory(dir: File): Boolean = {
try {
- // This sporadically fails - not sure why ... !dir.exists() &&
!dir.mkdirs()
- // So attempting to create and then check if directory was created or
not.
- dir.mkdirs()
- if ( !dir.exists() || !dir.isDirectory) {
- logError(s"Failed to create directory " + dir)
- }
- dir.isDirectory
+ // SPARK-35907 Instead of File#mkdirs, Files#createDirectories is
expected.
Review comment:
Shall we remove this line? Since `mkdirs` is removed already, we may
look weird after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
