cloud-fan commented on a change in pull request #33099:
URL: https://github.com/apache/spark/pull/33099#discussion_r659486480
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -911,6 +911,11 @@ object CollapseRepartition extends Rule[LogicalPlan] {
// we can remove the child.
case r @ RepartitionByExpression(_, child: RepartitionOperation, _) =>
r.copy(child = child.child)
+
+ // Case 3: When a RebalancePartitions has a child of Repartition or
RepartitionByExpression
+ // we can remove the child.
Review comment:
No, we can't do this. `RebalancePartitions` is a best-effort and does
not guarantee partitioning. We intentionally do not let `RebalancePartitions`
not extend `RepartitionOperation`, to avoid wrong optimizations.
Please revert this.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -911,6 +911,11 @@ object CollapseRepartition extends Rule[LogicalPlan] {
// we can remove the child.
case r @ RepartitionByExpression(_, child: RepartitionOperation, _) =>
r.copy(child = child.child)
+
+ // Case 3: When a RebalancePartitions has a child of Repartition or
RepartitionByExpression
+ // we can remove the child.
Review comment:
No, we can't do this. `RebalancePartitions` is a best-effort and does
not guarantee partitioning. We intentionally do not let `RebalancePartitions`
extend `RepartitionOperation`, to avoid wrong optimizations.
Please revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
