ulysses-you commented on a change in pull request #33079:
URL: https://github.com/apache/spark/pull/33079#discussion_r659609509



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ShuffledRowRDD.scala
##########
@@ -32,7 +32,16 @@ sealed trait ShufflePartitionSpec
 // `endReducerIndex` (exclusive).
 case class CoalescedPartitionSpec(
     startReducerIndex: Int,
-    endReducerIndex: Int) extends ShufflePartitionSpec
+    endReducerIndex: Int,
+    @transient dataSize: Option[Long] = None) extends ShufflePartitionSpec

Review comment:
       data size in normal code path (without AQE) is unknown. `ShuffledRowRDD`:
   ```
     def this(
         dependency: ShuffleDependency[Int, InternalRow, InternalRow],
         metrics: Map[String, SQLMetric]) = {
       this(dependency, metrics,
         Array.tabulate(dependency.partitioner.numPartitions)(i => 
CoalescedPartitionSpec(i, i + 1)))
     }
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to