dongjoon-hyun commented on a change in pull request #32753:
URL: https://github.com/apache/spark/pull/32753#discussion_r661195801
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetVectorUpdater.java
##########
@@ -30,20 +30,28 @@
* @param values destination values vector
* @param valuesReader reader to read values from
*/
- void updateBatch(
+ void readValues(
int total,
int offset,
WritableColumnVector values,
VectorizedValuesReader valuesReader);
+ /**
+ * Skip a batch of `total` values from `valuesReader`.
+ *
+ * @param total total number of values to skip
+ * @param valuesReader reader to skip values from
+ */
+ void skipValues(int total, VectorizedValuesReader valuesReader);
Review comment:
Since this is renamed, please update the following PR description
accordingly.
> introduced a new API ParquetVectorUpdater.skipBatch which skips a batch of
values from a Parquet value reader.
And, maybe, we had better update line 40 in this file.
> Skip a batch of ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
