karenfeng commented on a change in pull request #33164: URL: https://github.com/apache/spark/pull/33164#discussion_r661988466
########## File path: core/src/main/scala/org/apache/spark/SparkError.scala ########## @@ -1,83 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.spark - -import java.net.URL - -import scala.collection.immutable.SortedMap - -import com.fasterxml.jackson.annotation.JsonIgnore -import com.fasterxml.jackson.core.`type`.TypeReference -import com.fasterxml.jackson.databind.json.JsonMapper -import com.fasterxml.jackson.module.scala.DefaultScalaModule - -import org.apache.spark.util.Utils - -/** - * Information associated with an error class. - * - * @param sqlState SQLSTATE associated with this class. - * @param message C-style message format compatible with printf. - * The error message is constructed by concatenating the lines with newlines. - */ -private[spark] case class ErrorInfo(message: Seq[String], sqlState: Option[String]) { - // For compatibility with multi-line error messages - @JsonIgnore - val messageFormat: String = message.mkString("\n") -} - -/** - * Companion object used by instances of [[SparkError]] to access error class information and - * construct error messages. - */ -private[spark] object SparkError { - val errorClassesUrl: URL = - Utils.getSparkClassLoader.getResource("error/error-classes.json") - val errorClassToInfoMap: SortedMap[String, ErrorInfo] = { - val mapper: JsonMapper = JsonMapper.builder() - .addModule(DefaultScalaModule) - .build() - mapper.readValue(errorClassesUrl, new TypeReference[SortedMap[String, ErrorInfo]]() {}) - } - - def getMessage(errorClass: String, messageParameters: Seq[String]): String = { - val errorInfo = errorClassToInfoMap.getOrElse(errorClass, - throw new IllegalArgumentException(s"Cannot find error class '$errorClass'")) - String.format(errorInfo.messageFormat, messageParameters: _*) - } -} - -/** - * Trait mixed into exceptions thrown from Spark. - * - For backwards compatibility, existing exception types can be thrown with an arbitrary error - * message with no error class. See [[SparkException]]. - * - To promote standardization, exceptions should be thrown with an error class and message - * parameters to construct an error message with SparkError.getMessage(). New exception types - * should not accept arbitrary error messages. See [[SparkArithmeticException]]. - */ -trait SparkError extends Throwable { Review comment: Good call, it'll minimize the surface area of these changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
