cloud-fan commented on a change in pull request #32944: URL: https://github.com/apache/spark/pull/32944#discussion_r662517806
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/simpleCosting.scala ########## @@ -38,7 +38,7 @@ case class SimpleCost(value: Long) extends Cost { * A simple implementation of [[CostEvaluator]], which counts the number of * [[ShuffleExchangeLike]] nodes in the plan. */ -object SimpleCostEvaluator extends CostEvaluator { +case class SimpleCostEvaluator() extends CostEvaluator { Review comment: This can still be an object, if we follow https://github.com/apache/spark/pull/32944/files#r662513062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org