tdas commented on a change in pull request #33093: URL: https://github.com/apache/spark/pull/33093#discussion_r662652717
########## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala ########## @@ -1278,9 +1276,21 @@ class FlatMapGroupsWithStateSuite extends StateStoreMetricsTest { val flatMapGroupsWithStateFunc = (key: String, values: Iterator[String], state: GroupState[RunningCount]) => { val valList = values.toSeq + if (valList.isEmpty) { + // When the function is called on just the initial state make sure the other fields + // are set correctly + assert(state.exists) + assertCanGetProcessingTime { state.getCurrentProcessingTimeMs() >= 0 } + assertCannotGetWatermark { state.getCurrentWatermarkMs() } + assert(!state.hasTimedOut) Review comment: why does the last 3 tests need to be inside `if (valList.isEmpty) {`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org