dongjoon-hyun commented on a change in pull request #33140: URL: https://github.com/apache/spark/pull/33140#discussion_r662701897
########## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala ########## @@ -109,10 +109,12 @@ class SparkSessionExtensions { type FunctionDescription = (FunctionIdentifier, ExpressionInfo, FunctionBuilder) type TableFunctionDescription = (FunctionIdentifier, ExpressionInfo, TableFunctionBuilder) type ColumnarRuleBuilder = SparkSession => ColumnarRule - type QueryStagePrepRuleBuilder = SparkSession => Rule[SparkPlan] + type PhysicalPlanRuleBuilder = SparkSession => Rule[SparkPlan] private[this] val columnarRuleBuilders = mutable.Buffer.empty[ColumnarRuleBuilder] - private[this] val queryStagePrepRuleBuilders = mutable.Buffer.empty[QueryStagePrepRuleBuilder] + private[this] val queryStagePrepRuleBuilders = mutable.Buffer.empty[PhysicalPlanRuleBuilder] Review comment: ditto. I'd like to keep the old one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org