HyukjinKwon commented on a change in pull request #32944: URL: https://github.com/apache/spark/pull/32944#discussion_r662862925
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/costing.scala ########## @@ -17,16 +17,35 @@ package org.apache.spark.sql.execution.adaptive +import org.apache.spark.SparkConf +import org.apache.spark.internal.Logging import org.apache.spark.sql.execution.SparkPlan +import org.apache.spark.sql.internal.SQLConf +import org.apache.spark.util.Utils /** - * Represents the cost of a plan. + * An interface to represent the cost of a plan. */ trait Cost extends Ordered[Cost] /** - * Evaluates the cost of a physical plan. + * An interface to evaluate the cost of a physical plan. */ trait CostEvaluator { Review comment: whole execution package is for internal purpose. I don't think it makes much sense to make it pluggable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org