Peng-Lei commented on a change in pull request #33175:
URL: https://github.com/apache/spark/pull/33175#discussion_r663311232
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala
##########
@@ -128,6 +128,10 @@ class CatalogManager(
}
}
+ def listCatalogs(): mutable.HashMap[String, CatalogPlugin] = synchronized {
+ catalogs
Review comment:
Yeah, This behavior is desired for me because of that it is easy to get
and the displayed catalogs are meaningful because they can be loaded correctly.
But at now I think it is unreasonable. From the user's point of view, when he
uses this command, it should display all the catalogs that configured with conf
even if its configuration is incorrect and it cannot be loaded correctly. Thank
you very much @imback82 . I will rewrite this method by scanning the
configuration of conf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
