HyukjinKwon commented on a change in pull request #33188: URL: https://github.com/apache/spark/pull/33188#discussion_r663432910
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/exchange/EnsureRequirementsSuite.scala ########## @@ -133,4 +134,27 @@ class EnsureRequirementsSuite extends SharedSparkSession { }.size == 2) } } + + test("SPARK-35989: Do not remove REPARTITION_BY_NUM shuffle if AQE is enabled") { + import testImplicits._ + Seq(true, false).foreach { enableAqe => + withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> enableAqe.toString, + SQLConf.SHUFFLE_PARTITIONS.key -> "3", + SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1") { Review comment: nit: ```suggestion SQLConf.SHUFFLE_PARTITIONS.key -> "3", SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1") { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org