Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/5842#discussion_r29566893
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
---
@@ -77,4 +79,27 @@ private[sql] object StatFunctions {
})
counts.cov
}
+
+ /** Generate a table of frequencies for the elements of two columns. */
+ private[sql] def crossTabulate(df: DataFrame, col1: String, col2:
String): DataFrame = {
+ val tableName = s"${col1}_$col2"
+ val counts = df.groupBy(col1, col2).agg(col(col1), col(col2),
count("*")).collect()
+ // We need to sort the entries to pivot them properly
+ val sorted = counts.sortBy(r => (r.get(0).toString, r.get(1).toString))
+ val first = sorted.head.get(0)
+ // get the distinct values of column 2, so that we can make them the
column names
+ val distinctCol2 = sorted.takeWhile(r => r.get(0) == first)
--- End diff --
Good catch. Will add a test for it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
