cloud-fan commented on a change in pull request #33175:
URL: https://github.com/apache/spark/pull/33175#discussion_r664350699
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala
##########
@@ -128,6 +128,10 @@ class CatalogManager(
}
}
+ def listCatalogs(): mutable.HashMap[String, CatalogPlugin] = synchronized {
+ catalogs
Review comment:
Catalogs are lazily loaded. Before we load them, we don't know which
catalogs are available (people can set configs at runtime). This is a drawback
of using configs to load catalogs, we probably should use a more explicit way
to load/register a catalog.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala
##########
@@ -128,6 +128,10 @@ class CatalogManager(
}
}
+ def listCatalogs(): mutable.HashMap[String, CatalogPlugin] = synchronized {
+ catalogs
Review comment:
Catalogs are lazily loaded. Before we load them, we don't know which
catalogs are available (people can set configs at runtime). This is a drawback
of using configs to load catalogs, we probably should use a more explicit way
to load/register a catalog, but it's off-topic here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
