cloud-fan commented on a change in pull request #33229:
URL: https://github.com/apache/spark/pull/33229#discussion_r664397897
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeTestUtils.scala
##########
@@ -54,6 +55,13 @@ object DateTimeTestUtils {
"Europe/Amsterdam")
val outstandingZoneIds: Seq[ZoneId] = outstandingTimezonesIds.map(getZoneId)
+ private val random = new Random(System.nanoTime())
+
+ // Take 2 samples from the `outstandingZoneIds`. This is useful when the
test case is slow.
Review comment:
This might be too much. There are only 9 special timezones in total, and
it seems OK to always test all of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
