ekoifman commented on a change in pull request #32872:
URL: https://github.com/apache/spark/pull/32872#discussion_r666400930
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderExec.scala
##########
@@ -87,8 +87,22 @@ case class CustomShuffleReaderExec private(
Iterator(desc)
}
- def hasCoalescedPartition: Boolean =
- partitionSpecs.exists(_.isInstanceOf[CoalescedPartitionSpec])
+ private def isCoalesced(spec: ShufflePartitionSpec) = coalesceRange(spec) > 1
+
+ /**
+ * How many partitions were coalesced; 0 if not [[CoalescedPartitionSpec]]
+ */
+ private def coalesceRange(spec: ShufflePartitionSpec) = spec match {
+ case s: CoalescedPartitionSpec => s.endReducerIndex - s.startReducerIndex
+ case _ => 0
+ }
+
+ /**
+ * Returns true iff some non-empty partitions were combined
+ */
+ def hasCoalescedPartition: Boolean = {
+ partitionSpecs.exists(isCoalesced)
Review comment:
Could we please agree first on the substance of this PR? Specifically
the answer to https://github.com/apache/spark/pull/32872/files#r649658312?
If that makes sense I can make the other changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
