beliefer commented on a change in pull request #33258: URL: https://github.com/apache/spark/pull/33258#discussion_r667589186
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ########## @@ -968,6 +968,11 @@ object DateTimeUtils { */ def currentTimestamp(): Long = instantToMicros(Instant.now()) + /** + * Obtains the current local date-time as microseconds since the epoch in the default time-zone. + */ + def currentTimestampNTZ(): Long = localDateTimeToMicros(LocalDateTime.now()) Review comment: The Java class `java.time.LocalDateTime` has a similar semantic to ANSI SQL timestamp without timezone type, and it is the most suitable to be an external type for `TimestampWithoutTZType`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org