cloud-fan commented on a change in pull request #32401:
URL: https://github.com/apache/spark/pull/32401#discussion_r667669668
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1368,6 +1368,25 @@ package object config {
s"The buffer size must be greater than 0 and less than or equal to
${Int.MaxValue}.")
.createWithDefault(4096)
+ private[spark] val SHUFFLE_CHECKSUM_ENABLED =
+ ConfigBuilder("spark.shuffle.checksum.enabled")
+ .doc("Whether to calculate the checksum of shuffle output. If enabled,
Spark will try " +
+ "its best to tell if shuffle data corruption is caused by network or
disk or others.")
+ .version("3.3.0")
+ .booleanConf
+ .createWithDefault(true)
+
+ private[spark] val SHUFFLE_CHECKSUM_ALGORITHM =
+ ConfigBuilder("spark.shuffle.checksum.algorithm")
+ .doc("The algorithm used to calculate the checksum. Currently, it only
supports" +
+ " built-in algorithms of JDK.")
+ .version("3.3.0")
+ .stringConf
+ .transform(_.toLowerCase(Locale.ROOT))
+ .checkValue(Set("adler32", "crc32").contains, "Shuffle checksum
algorithm " +
+ "should be either Adler32 or CRC32.")
+ .createWithDefault("Adler32")
Review comment:
let's normalize the conf value with upper case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
