srowen commented on a change in pull request #33301:
URL: https://github.com/apache/spark/pull/33301#discussion_r667915510
##########
File path: core/src/main/scala/org/apache/spark/SSLOptions.scala
##########
@@ -78,6 +78,12 @@ private[spark] case class SSLOptions(
trustStore.foreach(file =>
sslContextFactory.setTrustStorePath(file.getAbsolutePath))
trustStorePassword.foreach(sslContextFactory.setTrustStorePassword)
trustStoreType.foreach(sslContextFactory.setTrustStoreType)
+ /*
+ * Need to pass needClientAuth flag to jetty for Jetty server to
authenticate
+ * client certificates. This would help enable mTLS authentication.
+ */
+ sslContextFactory.setNeedClientAuth(needClientAuth)
Review comment:
I suppose the argument could be 'true', or outside the if statement, but
no big deal.
Does this have any other side-effects that might break anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
