viirya commented on a change in pull request #33305:
URL: https://github.com/apache/spark/pull/33305#discussion_r668350912
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##########
@@ -1249,7 +1249,7 @@ class CodegenContext extends Logging {
// at least two nodes) as the cost of doing it is expected to be low.
val subExprCode = s"${addNewFunction(fnName, fn)}($INPUT_ROW);"
- subexprFunctions += s"${addNewFunction(fnName, fn)}($INPUT_ROW);"
Review comment:
`addNewFunction` will overwrite in the method map. So this won't add new
function. But it is better to avoid duplicatie call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
