eejbyfeldt commented on pull request #33205: URL: https://github.com/apache/spark/pull/33205#issuecomment-878826533
@mickjermsurawong-stripe I created a WIP PR with my branch here: https://github.com/apache/spark/pull/33316 I think you can just take the `getConstructorParameters` from there to make this patch handle case classes and tuples correctly. Let me know if you want me to make a patch. @cloud-fan You previously were involved in reviewing this PR: https://github.com/apache/spark/pull/22309 Could you provide some input with regards to the importance of backwards compatibility with schema changes for case classes. It does not seem like that was really dicussed when that patch was being proposed. Based on searches in the mailing lists and stackoverflow (and this being broken for so long) it would seem like a lot of people are not using this feature: http://apache-spark-user-list.1001560.n3.nabble.com/template/NamlServlet.jtp?macro=search_page&node=1&query=value+class&days=0 http://apache-spark-developers-list.1001551.n3.nabble.com/template/NamlServlet.jtp?macro=search_page&node=1&query=value+class&days=0 https://stackoverflow.com/search?tab=newest&q=%5Bapache-spark%5D%20%22value%20class%22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
