dongjoon-hyun commented on a change in pull request #33334:
URL: https://github.com/apache/spark/pull/33334#discussion_r669305829
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetColumnIndexSuite.scala
##########
@@ -31,96 +40,56 @@ class ParquetColumnIndexSuite extends QueryTest with
ParquetTest with SharedSpar
* |-------|-----|-----|---|---|---|---|---|
* col_2 400 300 200 200 200 200 200 200
*/
- def checkUnalignedPages(actions: (DataFrame => DataFrame)*): Unit = {
- withTempPath(file => {
- val ds = spark.range(0, 2000).map(i => (i, i + ":" + "o" * (i /
100).toInt))
- ds.coalesce(1)
- .write
- .option("parquet.page.size", "4096")
- .parquet(file.getCanonicalPath)
+ def checkUnalignedPages(df: DataFrame)(actions: (DataFrame => DataFrame)*):
Unit = {
+ Seq(true, false).foreach { enableDictionary =>
Review comment:
Thank you for adding this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
