cloud-fan commented on a change in pull request #30869: URL: https://github.com/apache/spark/pull/30869#discussion_r669674686
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ########## @@ -933,19 +934,36 @@ object DDLUtils { case HIVE_PROVIDER => val serde = table.storage.serde if (serde == HiveSerDe.sourceToSerDe("orc").get.serde) { - OrcFileFormat.checkFieldNames(colNames) + checkDataColNames("orc", colNames) } else if (serde == HiveSerDe.sourceToSerDe("parquet").get.serde || serde == Some("parquet.hive.serde.ParquetHiveSerDe") || serde == Some("org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe")) { - ParquetSchemaConverter.checkFieldNames(colNames) + checkDataColNames("parquet", colNames) + } else if (serde == HiveSerDe.sourceToSerDe("avro").get.serde) { + checkDataColNames("avro", colNames) } - case "parquet" => ParquetSchemaConverter.checkFieldNames(colNames) - case "orc" => OrcFileFormat.checkFieldNames(colNames) + case provider if Seq("parquet", "orc", "avro").contains(provider) => + checkDataColNames(provider, colNames) case _ => } } } + private[sql] def checkDataColNames(provider: String, colNames: Seq[String]): Unit = { + try { + DataSource.lookupDataSource(provider, SQLConf.get).getConstructor().newInstance() match { + case f: FileFormat => f.checkFieldNames(colNames) + case f: FileDataSourceV2 => f.checkFieldNames(colNames) Review comment: file source v2 have a better place to put this check: https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileTable.scala#L84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org