ueshin commented on a change in pull request #33331:
URL: https://github.com/apache/spark/pull/33331#discussion_r669820680
##########
File path: python/pyspark/pandas/tests/data_type_ops/test_categorical_ops.py
##########
@@ -44,6 +44,26 @@ def other_pser(self):
def other_psser(self):
return ps.from_pandas(self.other_pser)
+ @property
+ def ordered_pser(self):
+ return pd.Series([1, 2, 3]).astype(CategoricalDtype([3, 2, 1],
ordered=True))
+
+ @property
+ def disordered_psser(self):
Review comment:
btw, shall we put this below `ordered_psser`?
##########
File path: python/pyspark/pandas/tests/data_type_ops/test_categorical_ops.py
##########
@@ -44,6 +44,26 @@ def other_pser(self):
def other_psser(self):
return ps.from_pandas(self.other_pser)
+ @property
+ def ordered_pser(self):
+ return pd.Series([1, 2, 3]).astype(CategoricalDtype([3, 2, 1],
ordered=True))
+
+ @property
+ def disordered_psser(self):
Review comment:
nit: Sounds like this should be `unordered_psser`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
