sarutak commented on a change in pull request #33343: URL: https://github.com/apache/spark/pull/33343#discussion_r670123615
########## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ########## @@ -2004,12 +2005,16 @@ class DataSourceV2SQLSuite "USING foo", "OPTIONS(", "'from' = '0',", - "'to' = '1')", + "'to' = '1',", + "'via' = '2')", "PARTITIONED BY (a)", "COMMENT 'This is a comment'", "LOCATION '/tmp'", "TBLPROPERTIES(", - "'prop1' = '1')" + "'prop1' = '1',", + "'prop2' = '2',", + "'prop3' = '3',", + "'prop4' = '4')" Review comment: The modified test fails with both Scala `2.12` and `2.13` without the change in `ShowCreateTableExec.scala`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org