HyukjinKwon commented on a change in pull request #33379:
URL: https://github.com/apache/spark/pull/33379#discussion_r670921905
##########
File path: python/pyspark/sql/functions.py
##########
@@ -882,6 +882,12 @@ def approx_count_distinct(col, rsd=None):
def broadcast(df):
"""Marks a DataFrame as small enough for use in broadcast joins."""
Review comment:
don't document PySpark boradcast. deprecate `ps.broadcast` alone.
PySpark's `broadcast` has been there for a long time from since 1.6, and it
doesn't much make sense to deprecate it for legacy users.
##########
File path: python/pyspark/sql/functions.py
##########
@@ -882,6 +882,12 @@ def approx_count_distinct(col, rsd=None):
def broadcast(df):
"""Marks a DataFrame as small enough for use in broadcast joins."""
Review comment:
don't deprecate PySpark boradcast. deprecate `ps.broadcast` alone.
PySpark's `broadcast` has been there for a long time from since 1.6, and it
doesn't much make sense to deprecate it for legacy users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
