cloud-fan commented on a change in pull request #31522:
URL: https://github.com/apache/spark/pull/31522#discussion_r671082314
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
##########
@@ -307,6 +307,7 @@ object FileFormatWriter extends Logging {
dataWriter.writeWithIterator(iterator)
dataWriter.commit()
}
+
description.statsTrackers.foreach(_.updateTaskWriteAndCommitDuration(timeCost))
Review comment:
I should have pointed out this earlier: I don't think it makes sense to
report the write time, as it can be misleading. Consuming the iterator also
includes the time of executing the previous SQL operators.
Can we only track the task commit time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
