dongjoon-hyun commented on a change in pull request #33341:
URL: https://github.com/apache/spark/pull/33341#discussion_r671723488
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameTimeWindowingSuite.scala
##########
@@ -352,4 +463,31 @@ class DataFrameTimeWindowingSuite extends QueryTest with
SharedSparkSession {
)
}
}
+
+ test("SPARK-36091: Support TimestampNTZ type in expression TimeWindow") {
+ val df1 = Seq(
+ ("2016-03-27 19:39:30", 1, "a"),
+ ("2016-03-27 19:39:25", 2, "a")).toDF("time", "value", "id")
+ val df2 = Seq((LocalDateTime.parse("2016-03-27T19:39:30"), 1, "a"),
+ (LocalDateTime.parse("2016-03-27T19:39:25"), 2, "a")).toDF("time",
"value", "id")
+ val type1 = StructType(
+ Seq(StructField("start", TimestampType), StructField("end",
TimestampType)))
+ val type2 = StructType(
+ Seq(StructField("start", TimestampNTZType), StructField("end",
TimestampNTZType)))
+
+ Seq((df1, type1), (df2, type2)).foreach { tuple =>
Review comment:
indentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
