dongjoon-hyun commented on a change in pull request #33404: URL: https://github.com/apache/spark/pull/33404#discussion_r671729299
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveAggsThroughLeftSemiAntiJoin.scala ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.optimizer + +import org.apache.spark.sql.catalyst.plans.{LeftAnti, LeftSemi} +import org.apache.spark.sql.catalyst.plans.logical.{Aggregate, Join, LogicalPlan} +import org.apache.spark.sql.catalyst.rules.Rule +import org.apache.spark.sql.catalyst.trees.TreePattern.{AGGREGATE, LEFT_SEMI_OR_ANTI_JOIN} + +/** + * Remove the aggregation from left semi/anti join if the same aggregation has already been done + * on left side. + */ +object RemoveAggsThroughLeftSemiAntiJoin extends Rule[LogicalPlan] { + // Transform down to remove more Aggregates. + def apply(plan: LogicalPlan): LogicalPlan = plan.transformDownWithPruning( + _.containsAllPatterns(AGGREGATE, LEFT_SEMI_OR_ANTI_JOIN), ruleId) { + case agg @ Aggregate(grouping, aggExps, j @ Join(left: Aggregate, _, LeftSemi | LeftAnti, _, _)) + if agg.groupOnly && left.groupOnly && + aggExps.forall(e => left.aggregateExpressions.exists(_.semanticEquals(e))) && Review comment: This seems to assume `RemoveRepetitionFromGroupExpressions` always, but the test suite doesn't cover that. Can we add a more complex test case which needs `RemoveRepetitionFromGroupExpressions` explicitly? ########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveAggsThroughLeftSemiAntiJoin.scala ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.optimizer + +import org.apache.spark.sql.catalyst.plans.{LeftAnti, LeftSemi} +import org.apache.spark.sql.catalyst.plans.logical.{Aggregate, Join, LogicalPlan} +import org.apache.spark.sql.catalyst.rules.Rule +import org.apache.spark.sql.catalyst.trees.TreePattern.{AGGREGATE, LEFT_SEMI_OR_ANTI_JOIN} + +/** + * Remove the aggregation from left semi/anti join if the same aggregation has already been done + * on left side. + */ +object RemoveAggsThroughLeftSemiAntiJoin extends Rule[LogicalPlan] { + // Transform down to remove more Aggregates. + def apply(plan: LogicalPlan): LogicalPlan = plan.transformDownWithPruning( + _.containsAllPatterns(AGGREGATE, LEFT_SEMI_OR_ANTI_JOIN), ruleId) { + case agg @ Aggregate(grouping, aggExps, j @ Join(left: Aggregate, _, LeftSemi | LeftAnti, _, _)) + if agg.groupOnly && left.groupOnly && + aggExps.forall(e => left.aggregateExpressions.exists(_.semanticEquals(e))) && Review comment: This seems to assume `RemoveRepetitionFromGroupExpressions` always, but the test suite doesn't cover that. Can we add a more complex test case which needs `RemoveRepetitionFromGroupExpressions` explicitly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org