Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/5897#discussion_r29638709
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/bitset/BitSetMethods.java ---
@@ -71,7 +72,13 @@ public static boolean isSet(Object baseObject, long
baseOffset, int index) {
* Returns {@code true} if any bit is set.
*/
public static boolean anySet(Object baseObject, long baseOffset, long
bitSetWidthInBytes) {
- for (int i = 0; i <= bitSetWidthInBytes; i++) {
+ int widthInLong = (int)(bitSetWidthInBytes / SIZE_OF_LONG);
+ for (int i = 0; i <= widthInLong; i++) {
+ if (PlatformDependent.UNSAFE.getLong(baseObject, baseOffset + i) !=
0) {
+ return true;
+ }
+ }
+ for (int i = (int)(SIZE_OF_LONG * widthInLong); i <
bitSetWidthInBytes; i++) {
--- End diff --
I don't think so.
The second loop is for the remaining bytes :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
