viirya commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672793126
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala ########## @@ -41,7 +42,8 @@ import org.apache.spark.util.SerializableConfiguration abstract class FileFormatDataWriter( description: WriteJobDescription, taskAttemptContext: TaskAttemptContext, - committer: FileCommitProtocol) extends DataWriter[InternalRow] { + committer: FileCommitProtocol, + customMetrics: Map[String, SQLMetric]) extends DataWriter[InternalRow] { Review comment: I added custom metric for writing to InMemory table for test purpose. The tests are in `FileFormatDataWriterMetricSuite`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org