jhu-chang commented on a change in pull request #33263:
URL: https://github.com/apache/spark/pull/33263#discussion_r672813847
##########
File path: core/src/main/scala/org/apache/spark/util/logging/FileAppender.scala
##########
@@ -76,7 +80,13 @@ private[spark] class FileAppender(inputStream: InputStream,
file: File, bufferSi
}
}
} {
- closeFile()
+ try {
+ if (closeStreams) {
+ inputStream.close()
+ }
Review comment:
@Ngone51 @srowen
It's for both normal exit and exception.
Sorry, i don't quite understand the last comment: do you mean handling the
error from "inputStream.close()"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
