cloud-fan commented on a change in pull request #33212: URL: https://github.com/apache/spark/pull/33212#discussion_r672775023
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala ########## @@ -405,10 +405,18 @@ class JacksonParser( schema.getFieldIndex(parser.getCurrentName) match { case Some(index) => try { - row.update(index, fieldConverters(index).apply(parser)) + val fieldValue = fieldConverters(index).apply(parser) Review comment: That's another proposal I mentioned earlier: if the user-given schema is not-nullable, we just turn it into nullable schema and don't fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org