Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-99017279 Hey Imran - I had a few comments about enums I'm not sure whether we want to annotate private (I'll leave it to to you based on your intentions). Overall LGTM, feel free to pull this into Spark 1.4 if you are able to get to it in the next day or so. If not, let me know and we can talk about whether it can still go on.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org