ekoifman commented on a change in pull request #32776:
URL: https://github.com/apache/spark/pull/32776#discussion_r676750494
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderExec.scala
##########
@@ -182,6 +193,17 @@ case class CustomShuffleReaderExec private(
} else {
Map.empty
}
+ } ++ {
+ if (isLocalReader) {
Review comment:
I think so. For local reader all
`CustomShuffleReaderExec.partitionSpecs` should be `PartialMapperPartitionSpec`
so `hasCoalescedPartitions` is false, so `numCoalescedPartitions` metric
would always be `0`. It doesn't seem to add value to report it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
