mridulm commented on a change in pull request #33385:
URL: https://github.com/apache/spark/pull/33385#discussion_r677117650



##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala
##########
@@ -57,6 +57,7 @@ private[spark] class TaskDescription(
     val addedJars: Map[String, Long],
     val addedArchives: Map[String, Long],
     val properties: Properties,
+    val cpus: Int,

Review comment:
       Please add a check to make sure we dont have invalid value for `cpus` 
coming in - `assert(cpus > 0)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to