HyukjinKwon commented on a change in pull request #33364:
URL: https://github.com/apache/spark/pull/33364#discussion_r677306998
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -1980,6 +1980,9 @@ def dropDuplicates(self, subset=None):
|Alice| 5| 80|
+-----+---+------+
"""
+ if subset is not None and not isinstance(subset, (list, tuple)):
Review comment:
Okay, seems like it only works with list and tuple by py4j type
conversion. Seems fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
