itholic commented on a change in pull request #33562: URL: https://github.com/apache/spark/pull/33562#discussion_r678749415
########## File path: python/pyspark/pandas/generic.py ########## @@ -3180,6 +3180,7 @@ def __bool__(self) -> NoReturn: def _count_expr(spark_column: Column, spark_type: DataType) -> Column: # Special handle floating point types because Spark's count treats nan as a valid value, # whereas pandas count doesn't include nan. + # TODO: Make this work with DataTypeOps. Review comment: Maybe we want to create a related ticket for TODO and comment with ticket number ? e.g. `TODO(SPARK-xxxxx) Make this work with DataTypeOps.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org