c21 commented on a change in pull request #33565:
URL: https://github.com/apache/spark/pull/33565#discussion_r678758900
##########
File path:
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala
##########
@@ -231,12 +240,3 @@ object FileCommitProtocol extends Logging {
new Path(path, ".spark-staging-" + jobId)
}
}
-
-/**
- * The specification for Spark output file name.
- * This is used by [[FileCommitProtocol]] to create full path of file.
- *
- * @param prefix Prefix of file.
- * @param suffix Suffix of file.
- */
-final case class FileNameSpec(prefix: String, suffix: String)
Review comment:
I think because the companion object is defined here, so it cannot be
imported in other files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
