venkata91 commented on a change in pull request #33605:
URL: https://github.com/apache/spark/pull/33605#discussion_r681409675
##########
File path:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RemoteBlockPushResolverSuite.java
##########
@@ -1234,6 +1234,26 @@ void closeAndDeletePartitionFiles(Map<Integer,
AppShufflePartitionInfo> partitio
pushResolver.finalizeShuffleMerge(new FinalizeShuffleMerge(testApp,
NO_ATTEMPT_ID, 0, 3));
MergedBlockMeta mergedBlockMeta = pushResolver.getMergedBlockMeta(testApp,
0, 3, 0);
validateChunks(testApp, 0, 3, 0, mergedBlockMeta, new int[]{2}, new
int[][]{{0}});
+
+ StreamCallbackWithID stream4 =
+ pushResolver.receiveBlockDataAsStream(
+ new PushBlockStream(testApp, NO_ATTEMPT_ID, 0, 4, 0, 0, 0));
+ closed.acquire();
+ // Do not finalize shuffleMergeId 4 can happen during stage cancellation.
+ stream4.onData(stream4.getID(), ByteBuffer.wrap(new byte[2]));
+ stream4.onComplete(stream4.getID());
+
+ // Check whether the data is cleaned up when higher shuffleMergeId
finalize request comes
+ // but no blocks pushed for that shuffleMergeId
+ pushResolver.finalizeShuffleMerge(new FinalizeShuffleMerge(testApp,
NO_ATTEMPT_ID, 0, 5));
+ closed.acquire();
Review comment:
Explicitly checking for `!file.exists`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
