LuciferYang commented on pull request #33635:
URL: https://github.com/apache/spark/pull/33635#issuecomment-893176859


   > The changes look good but can you also run the examples that you're fixing 
manually to verify the changes?
   
   @HyukjinKwon 
   
   1. I manually verified `JavaUserDefinedScalar` with command 
   
   ```shell
   bin/spark-submit run-example 
org.apache.spark.examples.sql.JavaUserDefinedScalar
   ```
   The result is right
   
   2. I don't have a kinesis service to test now, so I revert the change of 
`JavaKinesisWordCountASL` in this pr
   3. I found the examples can't run in the IDE (such as IntelliJ), I created a 
new Jira( SPARK-36422 ) to  track it
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to