ekoifman commented on a change in pull request #33641:
URL: https://github.com/apache/spark/pull/33641#discussion_r685310606
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -79,6 +81,13 @@ case class AdaptiveSparkPlanExec(
case _ => logDebug(_)
}
+ override lazy val metrics = Map(
+ "num broadcast join conversions" ->
Review comment:
Making these proper metrics makes them show up in REST endpoints:
http://localhost:4040/api/v1/applications/local-1628523514017/sql/27/ (and
equivalent History Server Endpoint) which enables automation to be built.
That wouldn't easily work if this is just logged.
Why are these less "metrics" than number of partitions, for example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
