zsxwing commented on a change in pull request #33749: URL: https://github.com/apache/spark/pull/33749#discussion_r689302424
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala ########## @@ -62,8 +62,9 @@ class RocksDBStateStoreSuite extends StateStoreSuiteBase[RocksDBStateStoreProvid val testConfs = Seq( ("spark.sql.streaming.stateStore.providerClass", classOf[RocksDBStateStoreProvider].getName), - (RocksDBConf.ROCKSDB_CONF_NAME_PREFIX + ".compactOnCommit", "true"), - (RocksDBConf.ROCKSDB_CONF_NAME_PREFIX + ".lockAcquireTimeoutMs", "10") + (RocksDBConf.COMPACT_ON_COMMIT_CONF.fullName, "true"), Review comment: Changed this test to show the bug of `ConfEntry.fullName`: SQLConf is always case sensitive but currently `ConfEntry.fullName` returns an incorrect lower case name in the error message. This test will fail if we add `toLowerCase` back to `ConfEntry.fullName`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org