kevincmchen commented on a change in pull request #33746:
URL: https://github.com/apache/spark/pull/33746#discussion_r689492375



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
##########
@@ -118,6 +118,13 @@ private[spark] object HiveUtils extends Logging {
     .toSequence
     .createWithDefault(Nil)
 
+  val HIVE_METASTORE_METACONF_PREFIX = 
buildStaticConf("spark.sql.hive.metastore.metaconf.prefix")
+    .doc("the prefix of the meta conf in HiveMetastoreClient, which is used to 
extract " +

Review comment:
       > This sounds misleading because this PR calls `c.setMetaConf` instead 
of extracting. Can we use more direct terms to describe what this conf aims?
   
   cause we couldn't get the meta conf directly  and  the prefix is used to 
extract meta conf from HiveConf.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to