[GitHub] [spark] gengliangwang commented on a change in pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null

[GitBox]

gengliangwang commented on a change in pull request #33751:
URL: https://github.com/apache/spark/pull/33751#discussion_r689594580



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -204,7 +219,7 @@ object IntervalUtils {
    */
   def fromYearMonthString(input: String, startField: Byte, endField: Byte): 
CalendarInterval = {
     require(input != null, "Interval year-month string must be not null")
-    val months = castStringToYMInterval(UTF8String.fromString(input), 
startField, endField)
+    val months = castStringToYMIntervalAnsi(UTF8String.fromString(input), 
startField, endField)

Review comment:
       This one is used in the type constructor. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org