LuciferYang commented on a change in pull request #33748:
URL: https://github.com/apache/spark/pull/33748#discussion_r689630087
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/orc/OrcPartitionReaderFactory.scala
##########
@@ -158,6 +169,10 @@ case class OrcPartitionReaderFactory(
val taskAttemptContext = new TaskAttemptContextImpl(taskConf, attemptId)
val batchReader = new OrcColumnarBatchReader(capacity)
+ if (orcMetaCacheEnabled) {
+ val tail = OrcFileMeta.readTailFromCache(filePath, conf)
Review comment:
42d2bfd change
```
def readTailFromCache(path: Path, conf: Configuration): OrcTail =
readTailFromCache(OrcFileMetaKey(path, conf))
```
to
```
def readTailFromCache(path: Path, conf: Configuration): OrcTail =
FileMetaCacheManager.get(OrcFileMetaKey(path,
conf)).asInstanceOf[OrcFileMeta].tail
```
and remove a redundant method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
