LuciferYang commented on a change in pull request #33748:
URL: https://github.com/apache/spark/pull/33748#discussion_r690007555
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -154,11 +155,18 @@ class OrcFileFormat
(file: PartitionedFile) => {
val conf = broadcastedConf.value.value
+ val metaCacheEnabled =
+ conf.getBoolean(SQLConf.FILE_META_CACHE_ORC_ENABLED.key, false)
val filePath = new Path(new URI(file.filePath))
val fs = filePath.getFileSystem(conf)
- val readerOptions = OrcFile.readerOptions(conf).filesystem(fs)
+ val readerOptions = if (metaCacheEnabled) {
+ val tail = OrcFileMeta.readTailFromCache(filePath, conf)
+ OrcFile.readerOptions(conf).filesystem(fs).orcTail(tail)
Review comment:
If it is manually replaced and the file has the same name and the
corresponding file meta exists in the cache, an incorrect file meta will be
used to read the data. If the data reading fails, the job will fail. But if the
data reading happens to be successful, the job will read the wrong data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
