itholic opened a new pull request #33757:
URL: https://github.com/apache/spark/pull/33757


   ### What changes were proposed in this pull request?
   
   This PR proposes to fix the behavior of `astype` for `CategoricalDtype` to 
follow pandas 1.3.
   
   
   **Before:**
   ```python
   >>> pcat
   0    a
   1    b
   2    c
   dtype: category
   Categories (3, object): ['a', 'b', 'c']
   
   >>> pcat.astype(CategoricalDtype(["b", "c", "a"]))
   0    a
   1    b
   2    c
   dtype: category
   Categories (3, object): ['b', 'c', 'a']
   ```
   
   **After:**
   ```python
   >>> pcat
   0    a
   1    b
   2    c
   dtype: category
   Categories (3, object): ['a', 'b', 'c']
   
   >>> pcat.astype(CategoricalDtype(["b", "c", "a"]))
   0    a
   1    b
   2    c
   dtype: category
   Categories (3, object): ['a', 'b', 'c']  # CategoricalDtype is not updated 
if dtype is the same
   ```
   
   `CategoricalDtype` is treated as a same `dtype` if the unique values are the 
same.
   
   ```python
   >>> pcat1 = pser.astype(CategoricalDtype(["b", "c", "a"]))
   >>> pcat2 = pser.astype(CategoricalDtype(["a", "b", "c"]))
   >>> pcat1.dtype == pcat2.dtype
   True
   ```
   
   ### Why are the changes needed?
   
   We should follow the latest pandas as much as possible.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, the behavior is changed as example in the PR description.
   
   ### How was this patch tested?
   
   Unittest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to