AngersZhuuuu commented on a change in pull request #33736: URL: https://github.com/apache/spark/pull/33736#discussion_r690070608
########## File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala ########## @@ -333,3 +340,22 @@ class TPCDSModifiedPlanStabilityWithStatsSuite extends PlanStabilitySuite { } } } + +abstract class TPCHPlanStabilitySuiteBase extends PlanStabilitySuite { Review comment: > why add an abstract class that has only one child? Have [withState] subclass before but found not have stats data then remove it. Remove TPCHPlanStabilitySuiteBase now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org