cloud-fan commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r690234889
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala
##########
@@ -66,7 +66,7 @@ import org.apache.spark.sql.internal.SQLConf
* }}}
*/
// scalastyle:on line.size.limit
-trait PlanStabilitySuite extends TPCDSBase with DisableAdaptiveExecutionSuite {
+trait PlanStabilitySuite extends TPCDSBase with TPCHBase with
DisableAdaptiveExecutionSuite {
Review comment:
It's a bit weird that `TPCDSBase` and `TPCHBase` are not at the same
level (`TPCDSBase` is much more complicated). Can we do a bit more refactoring?
Probably pull out some logic (e.g. `createTable`) from `TPCDSBase` to
`PlanStabilitySuite` or a new `trait`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
